Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify icon with standard char #75

Closed
wants to merge 1 commit into from
Closed

fix: modify icon with standard char #75

wants to merge 1 commit into from

Conversation

zulkhair
Copy link
Collaborator

@zulkhair zulkhair commented Sep 4, 2024 •
edited
Loading

Closes: WORLD-1178 & WORLD-1179

Overview

Currently cmd and powershell in windows cannot read tick and cross icon from world CLI

Brief Changelog

Change icon to standard char

  • tick -> OK
  • cross -> FAIL
  • Todo -> -
  • Double Right -> >>
  • Chevron -> >

Testing and Verifying

Manually tested

image.png

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 4, 2024 •
edited
Loading

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zulkhair Graphite App
Copy link
Collaborator Author

zulkhair commented Sep 4, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zulkhair and the rest of your teammates on Graphite Graphite

@zulkhair zulkhair changed the title modify icon with standard char fix: modify icon with standard char Sep 4, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “graphite/merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@zulkhair zulkhair marked this pull request as ready for review September 4, 2024 17:44
@ellipsis-dev ellipsis.dev
Copy link

ellipsis-dev bot commented Sep 4, 2024

Your free trial has expired. To keep using Ellipsis, sign up at https://app.ellipsis.dev for $20/seat/month or reach us at [email protected]

@zulkhair zulkhair force-pushed the daim/modify_icon_with_standard_char branch from 76e3a5b to 16339e8 Compare September 4, 2024 18:04
@codecov Codecov
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.58%. Comparing base (096d3c4) to head (16339e8).

Additional details and impacted files 
@@                      Coverage Diff                      @@
##           daim/check_git_configuration      #75   +/-   ##
=============================================================
  Coverage                         47.58%   47.58%           
=============================================================
  Files                                52       52           
  Lines                              2360     2360           
=============================================================
  Hits                               1123     1123           
  Misses                             1039     1039           
  Partials                            198      198

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smsunarto
Copy link
Member

smsunarto commented Sep 8, 2024 •
edited
Loading

I don't think we intend to support powershell/cmd to begin with; we should encourage windows users to use it via WSL. Providing Windows support in the long term is too much of a rabbithole in my opinion.

@smsunarto smsunarto closed this Sep 8, 2024
This was referenced Sep 11, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmrt1n rmrt1n Awaiting requested review from rmrt1n

@smsunarto smsunarto Awaiting requested review from smsunarto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zulkhair @smsunarto